Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix C++17 mode compilation with Apple clang #721

Merged
merged 1 commit into from
Nov 22, 2018
Merged

Fix C++17 mode compilation with Apple clang #721

merged 1 commit into from
Nov 22, 2018

Conversation

traceon
Copy link
Contributor

@traceon traceon commented Nov 21, 2018

Fixes the following compilation error:

benchmark/test/output_test_helper.cc:206:28: error: no member named 'streampos' in 'std::__1::basic_ios<char>'

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@traceon
Copy link
Contributor Author

traceon commented Nov 21, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@EricWF
Copy link
Contributor

EricWF commented Nov 21, 2018

LGTM, but I'll wait for the bots to cycle before merging this.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.288% when pulling 702c97b on traceon:fix-cpp17-compilation into b171791 on google:master.

@AppVeyorBot
Copy link

Build benchmark 1567 completed (commit de980c4f19 by @traceon)

@EricWF EricWF merged commit 56f5cd6 into google:master Nov 22, 2018
@traceon traceon deleted the fix-cpp17-compilation branch November 22, 2018 02:58
@dmah42
Copy link
Member

dmah42 commented Nov 22, 2018

thank you!

EricWF pushed a commit to efcs/benchmark that referenced this pull request Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants