-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Error C2146 and error C4430 in MSVC. #854
Conversation
Replace ‘constexpr’ with 'const', for Visual Studio 2013. Fixes google#853 CLA: trivial
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
CLA: trivial |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
The documentation says that the library requires C++11 to build. Why are we reverting to C++03, and why do we believe that this is the only problem? The main support end date for VS 2013 was April 9, 2019. Let it rest in peace. |
Relevant: eb8cbec |
VS2013 is unsupported since google#691 / google@eb8cbec but i forgot to update docs. References: * google#689 * google#691 * google/googletest#1815 * google#853 * google#854
Replace ‘constexpr’ with 'const', for Visual Studio 2013.
Fixes #853
CLA: trivial