Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Error C2146 and error C4430 in MSVC. #854

Closed

Conversation

joe2018Outlookcom
Copy link

Replace ‘constexpr’ with 'const', for Visual Studio 2013.
Fixes #853
CLA: trivial

Replace ‘constexpr’ with 'const', for Visual Studio 2013.
Fixes google#853
CLA: trivial
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@joe2018Outlookcom
Copy link
Author

CLA: trivial

@joe2018Outlookcom
Copy link
Author

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@pleroy
Copy link
Contributor

pleroy commented Aug 21, 2019

The documentation says that the library requires C++11 to build. Why are we reverting to C++03, and why do we believe that this is the only problem?

The main support end date for VS 2013 was April 9, 2019. Let it rest in peace.

@LebedevRI
Copy link
Collaborator

Relevant: eb8cbec
I'm going to close this.

@LebedevRI LebedevRI closed this Aug 21, 2019
LebedevRI added a commit that referenced this pull request Aug 21, 2019
VS2013 is unsupported since #691 / eb8cbec
but i forgot to update docs.
References:
* #689
* #691
* google/googletest#1815
* #853
* #854
JBakamovic pushed a commit to JBakamovic/benchmark that referenced this pull request Sep 11, 2020
VS2013 is unsupported since google#691 / google@eb8cbec
but i forgot to update docs.
References:
* google#689
* google#691
* google/googletest#1815
* google#853
* google#854
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error C2146 and error C4430 in benchmark_runner.cc(62).
4 participants