Timeline semaphores #315
Merged
Timeline semaphores #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apazylbe
reviewed
Oct 14, 2023
Keenuts
approved these changes
Oct 18, 2023
apazylbe
approved these changes
Oct 19, 2023
dnovillo
reviewed
Oct 19, 2023
apazylbe
force-pushed
the
timeline_semaphore
branch
from
883ce99 to
0b4398f
Compare
This CL adds timeline semaphore support for both APIs. grfx::Semaphore is modified to support both binary and timeline semaphores similar to how Vulkan does it. This CL also makes the Vulkan queues thread safe. - Modified vk::Queue to be thread safe. - Added timeline semaphore support for Vulkan and D3D12. - Added sample demonstrating timeline semaphore.
- Fixed typos and errors in comments - Fixed copyright year - Moved timeline asserts from API level to grfx level
apazylbe
force-pushed
the
timeline_semaphore
branch
from
0b4398f to
10b3a0f
Compare
|
Seems like there is only one thing outstanding, any objections to merging this and addressing in follow up PRs if needed? |
This CL adds timeline semaphore support for both APIs. grfx::Semaphore is modified to support both binary and timeline semaphores similar to how Vulkan does it. This CL also makes the Vulkan queues thread safe. - Modified vk::Queue to be thread safe. - Added timeline semaphore support for Vulkan and D3D12. - Added sample demonstrating timeline semaphore.
- Fixed typos and errors in comments - Fixed copyright year - Moved timeline asserts from API level to grfx level
- Removed the CPU to CPU sync test cases since there's not really any practical use case for this. - Removed forceMonotonic flag from grfx::Semaphore::Signal since it obfuscates the intentions of the underlying APIs. This unfortunately subjects an app to UB, but doing otherwise might lead the app to believing it's handling its semaphores correctly when it's not.
apazylbe
approved these changes
Feb 21, 2024
GrantComm
pushed a commit
to GrantComm/bigwheels
that referenced
this pull request
Mar 20, 2024
This CL adds timeline semaphore support for both APIs. grfx::Semaphore is modified to support both binary and timeline semaphores similar to how Vulkan does it. This CL also makes the Vulkan queues thread safe. - Modified vk::Queue to be thread safe. - Added timeline semaphore support for Vulkan and D3D12. - Added sample demonstrating timeline semaphore. --------- Co-authored-by: Aliya Pazylbekova <39095209+apazylbe@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds timeline semaphore support for both APIs. grfx::Semaphore is modified to support both binary and timeline semaphores similar to how Vulkan does it. This CL also makes the Vulkan queues thread safe.