Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add foveation benchmark #491

Merged
merged 10 commits into from
Jul 18, 2024
Merged

Conversation

jorgeag-google
Copy link
Collaborator

@jorgeag-google jorgeag-google commented Jul 11, 2024

The third of a series of CL that integrates the commits from:

https://github.com/bjoeris/bigwheels/tree/experimental-foveation

into BW main's branch.

The series will have 4 CL, this is the third one that integrates the following commit

Add foveation benchmark

Beside the foveation sample app, it also

  • Adds ImmutableSamplers member to DescrptorBinding struct
  • Refactor code from TakeScreenshot and adds a SaveImage member in Application class
  • Adds a cmake function to add a GLSL shader target

CMakeLists.txt Outdated Show resolved Hide resolved
assets/basic/shaders/FullScreenTriangleCombined.hlsl Outdated Show resolved Hide resolved
assets/basic/shaders/FullScreenTriangleCombined.hlsl Outdated Show resolved Hide resolved
assets/benchmarks/shaders/CMakeLists.txt Outdated Show resolved Hide resolved
assets/benchmarks/shaders/FoveationBenchmark.hlsl Outdated Show resolved Hide resolved
benchmarks/foveation/main.cpp Show resolved Hide resolved
benchmarks/foveation/main.cpp Outdated Show resolved Hide resolved
benchmarks/foveation/main.cpp Outdated Show resolved Hide resolved
benchmarks/foveation/main.cpp Outdated Show resolved Hide resolved
benchmarks/foveation/main.cpp Outdated Show resolved Hide resolved
@jorgeag-google
Copy link
Collaborator Author

I adress the simple changes, this is a save progress commit. I will continue tomorrow

Copy link
Collaborator

@bjoeris bjoeris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@apazylbe apazylbe requested a review from Keenuts July 18, 2024 14:48
Copy link
Collaborator

@apazylbe apazylbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't looked in detail at the project code, but otherwise lgtm.
Could you please update the PR description to actually describe the changes? When we refer to history it might not be as useful to know that this was one of the few changes to be merged. For example, describe changes to bigwheels itself (immutable samplers, application take screenshot) or the foveation benchmark itself.

src/ppx/application.cpp Outdated Show resolved Hide resolved
@jorgeag-google jorgeag-google merged commit 923280e into google:main Jul 18, 2024
5 checks passed
@jorgeag-google jorgeag-google deleted the integration3 branch July 19, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants