-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add foveation benchmark #491
Conversation
I adress the simple changes, this is a save progress commit. I will continue tomorrow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't looked in detail at the project code, but otherwise lgtm.
Could you please update the PR description to actually describe the changes? When we refer to history it might not be as useful to know that this was one of the few changes to be merged. For example, describe changes to bigwheels itself (immutable samplers, application take screenshot) or the foveation benchmark itself.
The third of a series of CL that integrates the commits from:
https://github.com/bjoeris/bigwheels/tree/experimental-foveation
into BW main's branch.
The series will have 4 CL, this is the third one that integrates the following commit
Add foveation benchmark
Beside the foveation sample app, it also