Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scale the spheres #535

Merged
merged 2 commits into from
Dec 9, 2024
Merged

scale the spheres #535

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc6c362
scale the spheres
RenfengLiu Dec 6, 2024
24b6b2c
scale the sphere with factor of 20
RenfengLiu Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion benchmarks/graphics_pipeline/SphereMesh.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ float4x4 OrderedGrid::GetModelMatrix(uint32_t sphereIndex, bool isXR) const
z *= -1.0;
}

return glm::translate(float3(x * mStep, y * mStep, z * mStep));
return glm::translate(float3(x * mStep, y * mStep, z * mStep)) * glm::scale(float3(5.f, 5.f, 5.f));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is 5 large enough?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the effect of 5.0

50 is way too large and can only see the pink/red color

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i feel 5 is still too small as the spheres only covers less than 1/9 of the screen. were you able to see diff in the alpha blending test with scale factor of 5?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, the result posted in the chat is the result of this scale

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my worry is that with 1/9 overage, some difference might be less than noise. how about 20? (so that at least we covers about ~2/3 screen)

}

// =====================================================================
Expand Down