Skip to content

Commit

Permalink
Make architecture names case insensitive.
Browse files Browse the repository at this point in the history
Architecture names do not always come lower case. For example, IDA plugin does not do that: https://github.com/google/binexport/blob/a8572981126e455b99ba813edbc9a88a3269d8b6/ida/names.cc#L101

PiperOrigin-RevId: 691769928
Change-Id: I3014e85201cb6d66c7f8f17210bfc05f419100b7
  • Loading branch information
BinExport Authors authored and copybara-github committed Oct 31, 2024
1 parent 3a9eeea commit 81ea3e4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions reader/flow_graph.cc
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ namespace security::binexport {
namespace {

absl::optional<Architecture> GetSupportedArchitecture(const BinExport2& proto) {
const std::string& architecture =
proto.meta_information().architecture_name();
const std::string architecture =
absl::AsciiStrToLower(proto.meta_information().architecture_name());
if (architecture == "arm") {
return Architecture::kArm;
}
Expand Down

0 comments on commit 81ea3e4

Please sign in to comment.