Refactored the DWARF parser #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a monolith it was getting unmanageable
DWARF5 introduced new representations for location lists and range lists. The index processing is dependent on the form, with `DW_FORM_sec_offset` and `DW_FORM_loclistx`. Process the `DW_FORM_locklistx` when processing the DWARF though we still only read the `DW_FORM_sec_offset` representation of the location. Explicitly check the encoding type before getting the location to avoid spurious warnings. Ported from e2ee0c8
Also did some refactoring.
The offset computation needs to account for the stride (4-bytes by default in DWARF). Account for the difference in stride width for DWARF64, which uses a 8-byte stride. Applied from 2151c24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring achieves two main goals:
src/dwarf.cc, which had grown very large, into several smaller files..debug_infoparsing classes into better abstractions. TheDIEReaderclass was too large and the control flow was convoluted. The new classesInfoReader,CUIter,CU, andDIEReaderhave both simpler implementations and better interfaces.