Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cross-tab-copy-paste can copy a block from inside the bubble to outside the bubble. #1169

Closed
Taikono-Himazin opened this issue Jun 21, 2022 · 4 comments · Fixed by #1304
Closed

cross-tab-copy-paste can copy a block from inside the bubble to outside the bubble. #1169

Taikono-Himazin opened this issue Jun 21, 2022 · 4 comments · Fixed by #1304
Assignees
@debaraj-barua
Labels
category: plugin Anything in the plugins folder good first issue Good for newcomers type: bug Something isn't working

Comments

@Taikono-Himazin
Copy link
Contributor

cross-tab-copy-paste can copy a block from inside the bubble to outside the bubble.
image

image

This will cause an error when generating the code.
Right-clicking is prohibited in the bubble, but you can copy using the shortcut key.
@Taikono-Himazin Taikono-Himazin added triage type: bug Something isn't working labels Jun 21, 2022
@maribethb maribethb added category: plugin Anything in the plugins folder and removed triage labels Jun 24, 2022
@BeksOmega
Copy link
Contributor

BeksOmega commented Aug 4, 2022 •
edited
Loading

Fixing this issue has a few steps:

  1. Reproduce the issue using the steps outlined in the "To Reproduce" section. Once you can reproduce the bad behavior, you can test if your changes fixed it.
  2. Modify the code in plugins/cross-tab-copy-paste/src/index.js so that the precondition function of the copy shortcut returns false if the block is in a mutator workspace.
  3. Run the reproduction steps again, and verify that the blocks cannot be copied from inside the mutator to outside of the mutator.
  4. Open your PR and resolve any PR comments.

After your PR is accepted, a Blockly team member will have to publish the GitHub Pages site, and then you'll be able to see your change live!

@BeksOmega BeksOmega mentioned this issue Aug 4, 2022
Merged
4 tasks
@BeksOmega BeksOmega removed the triage label Aug 8, 2022
@BeksOmega BeksOmega added good first issue Good for newcomers and removed ghc-osd labels Sep 1, 2022
@debaraj-barua
Copy link
Contributor

Is this task still open? If so, can I pick this up?

@alschmiedt
Copy link
Contributor

Yup! @debaraj-barua I just assigned you : )

debaraj-barua added a commit to debaraj-barua/blockly-samples that referenced this issue Sep 26, 2022
@debaraj-barua
fix google#1169: avoid copy from inside context menus
5422052
debaraj-barua added a commit to debaraj-barua/blockly-samples that referenced this issue Sep 26, 2022
@debaraj-barua
fix: avoid copy from inside context menus
2d374cd 
fixes google#1169
@debaraj-barua debaraj-barua mentioned this issue Sep 26, 2022
Merged
alschmiedt pushed a commit that referenced this issue Sep 27, 2022
@debaraj-barua
fix: avoid copy from inside context menus (#1304)
3d4ef16 
fixes #1169
@Taikono-Himazin
Copy link
Contributor Author

Taikono-Himazin commented Sep 29, 2022 •
edited
Loading

@debaraj-barua
Thanks for the fix!
I can't wait for the release of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@debaraj-barua debaraj-barua

Labels
category: plugin Anything in the plugins folder good first issue Good for newcomers type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: avoid copy from inside context menus debaraj-barua/blockly-samples
5 participants
@maribethb @debaraj-barua @alschmiedt @BeksOmega @Taikono-Himazin