Fix margins/checkbox in RTL dropdown menus (#2356)

Fixes #2337 by adding in correct positioning for RTL selected states and fixing an incorrect margin value.
google · Apr 5, 2019 · 5056e23 · 5056e23
1 parent dcbac91
commit 5056e23
Showing 1 changed file with 10 additions and 1 deletion.
diff --git a/core/css.js b/core/css.js
@@ -874,7 +874,7 @@ Blockly.Css.CONTENT = [
   '.blocklyWidgetDiv .goog-menuitem.goog-menuitem-rtl, ',
   '.blocklyDropDownDiv .goog-menuitem.goog-menuitem-rtl {',
      /* Flip left/right padding for BiDi. */
-    'padding-left: 7em;',
+    'padding-left: 5px;',
     'padding-right: 28px;',
   '}',
 
@@ -970,6 +970,15 @@ Blockly.Css.CONTENT = [
     'margin-left: -24px;',
   '}',
 
+  '.blocklyWidgetDiv .goog-menuitem-rtl .goog-menuitem-checkbox, ',
+  '.blocklyWidgetDiv .goog-menuitem-rtl .goog-menuitem-icon, ',
+  '.blocklyDropDownDiv .goog-menuitem-rtl .goog-menuitem-checkbox, ',
+  '.blocklyDropDownDiv .goog-menuitem-rtl .goog-menuitem-icon {',
+    'float: right;',
+    'margin-right: -24px;',
+  '}',
+
+
   /* Keyboard shortcut ("accelerator") style. */
   '.blocklyWidgetDiv .goog-menuitem-accel, ',
   '.blocklyDropDownDiv .goog-menuitem-accel {',