Skip to content

Commit

Permalink
fix: insertion marker's next blocks become real block (#7384)
Browse files Browse the repository at this point in the history
Don't add next block to the insertion marker when we do
an insertion marker json serialization.

Also, to keep consistent with the old behavior, we don't
need to add input blocks for the insertion marker.

And we don't need to do a full serialization here as it
will just become an insertion marker.

Resolves #7383

Address issues in PR #7364

Signed-off-by: Hollow Man <hollowman@opensuse.org>
(cherry picked from commit 18ee0ec)
  • Loading branch information
HollowMan6 authored and ericblackmonGoogle committed Aug 14, 2023
1 parent 11b7b72 commit 5e85cde
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion core/insertion_marker_manager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,12 @@ export class InsertionMarkerManager {
eventUtils.disable();
let result: BlockSvg;
try {
const blockJson = blocks.save(sourceBlock);
const blockJson = blocks.save(sourceBlock, {
addCoordinates: false,
addInputBlocks: false,
addNextBlocks: false,
doFullSerialization: false,
});
if (!blockJson) {
throw new Error('Failed to serialize source block.');
}
Expand Down

0 comments on commit 5e85cde

Please sign in to comment.