chore: clean up insertion marker code (#6602)

* chore: move comments * chore: remove underscores from private property names * chore: remove underscores from properties and methods in insertion marker manager * chore: format * chore: track closestConnection and localConnection as a single object * chore: format * chore: add comments and simplify shouldUpdatePreviews * chore(docs): add jsdoc for new params * chore: use destructuring assignments * chore: improve readability * chore: address review feedback * chore: respond to review feedback * chore: fix types in shouldDelete * chore: make wouldDeleteBlock a property * chore: format
google · Nov 10, 2022 · 92efdb9 · 92efdb9
1 parent 1f862cb
commit 92efdb9
Show file tree

Hide file tree

Showing 3 changed files with 249 additions and 317 deletions.
diff --git a/core/block_dragger.ts b/core/block_dragger.ts
@@ -187,7 +187,7 @@ export class BlockDragger implements IBlockDragger {
 
     this.draggedConnectionManager_.update(delta, this.dragTarget_);
     const oldWouldDeleteBlock = this.wouldDeleteBlock_;
-    this.wouldDeleteBlock_ = this.draggedConnectionManager_.wouldDeleteBlock();
+    this.wouldDeleteBlock_ = this.draggedConnectionManager_.wouldDeleteBlock;
     if (oldWouldDeleteBlock !== this.wouldDeleteBlock_) {
       // Prevent unnecessary add/remove class calls.
       this.updateCursorDuringBlockDrag_();