fix: Theme.name does not match registered name (#6186) (#6226)

* fix: Theme.name does not match registered name (#6186) * chore(tests): add test for defineTheme normalizing to lower case
google · Jun 23, 2022 · 9797943 · 9797943
1 parent 233cce8
commit 9797943
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/core/theme.js b/core/theme.js
@@ -149,6 +149,7 @@ class Theme {
    * @return {!Theme} A new Blockly theme.
    */
   static defineTheme(name, themeObj) {
+    name = name.toLowerCase();
     const theme = new Theme(name);
     let base = themeObj['base'];
     if (base) {

diff --git a/tests/mocha/theme_test.js b/tests/mocha/theme_test.js
@@ -274,4 +274,11 @@ suite('Theme', function() {
           this.constants.validatedBlockStyle_(inputStyle), expectedOutput);
     });
   });
+
+  suite('defineTheme', function() {
+    test('Normalizes to lowercase', function() {
+      const theme = Blockly.Theme.defineTheme('TEST', {});
+      chai.assert.equal(theme.name, 'test');
+    });
+  });
 });