Merge pull request #7859 from BeksOmega/fix/previewer-disposing

fix: connection previewer disposing too early
google · Feb 15, 2024 · da3ec25 · da3ec25
2 parents e59df7b + 9e46ed7
commit da3ec25
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/core/block_dragger.ts b/core/block_dragger.ts
@@ -382,7 +382,6 @@ export class BlockDragger implements IBlockDragger {
 
     blockAnimation.disconnectUiStop();
     this.connectionPreviewer.hidePreview();
-    this.connectionPreviewer.dispose();
 
     const preventMove =
       !!this.dragTarget_ &&
@@ -417,6 +416,9 @@ export class BlockDragger implements IBlockDragger {
         );
       }
     }
+    // Must dispose after `updateBlockAfterMove_` is called to not break the
+    // dynamic connections plugin.
+    this.connectionPreviewer.dispose();
     this.workspace_.setResizesEnabled(true);
 
     eventUtils.setGroup(false);