Overriding color constants does not override all blocks with given color

[AnmAtAnm]

Problem statement

Overriding color constants does not override all blocks with given color.

Expected Behavior

Overriding a Blockly color constant after loading the blocks_compressed.js and before constructing a block (ideally before injecting Blockly) should affect all blocks using the color constant.

Actual Behavior

Several block types have the incorrect color, at least among the text blocks.

Steps to Reproduce

1. Add the following lines to the top of the first <script> in the Playground (right after 'use strict'):

Blockly.Msg.TEXTS_HUE = "#193863";  // dark blue

2. Load the Playground and open the text blocks toolbox category. Note the mix of block colors:

Operating System and Browser

• Desktop Chrome

[CleoQc]

For historical purposes, this used to work with the code from a year ago. I don't know when the bug was introduced but it has been working for us before.

Thanks for creating the issue for me.

Cleo

[swdunning]

After trying to change the color of the Loops and Conditionals and not being successful I was told to go here. This is also happening with me. The blocks look almost exactly the same, first half are green and second half is blue.

[swdunning]

Also, this only happens if I add both lines of code to the "start" function, only adding the first line of code does nothing and adding them to the <script> tag does nothing either....Although, I am not sure I am doing it correctly....

<script Blockly.Constants.Text.HUE = "#193863"; src="../blo....>

[AnmAtAnm]

@swdunningASU: The correct form is:

<script>
'use strict';
Blockly.Msg.TEXTS_HUE = "#193863";  // dark blue

.
.
.

[AnmAtAnm]

I incorrectly wrote the bug referring to the old method of setting the color. Since the move to JSON required message references, I've updated the above bug report and comments to hint at a preference of updating the Blockly.Msg constant, instead of the prior HUE constant.

A PR with all blocks using the MSG constants is forthcoming.

[AnmAtAnm]

Just for clarification, the original version of this bug report suggested Blockly.Constants.Text.HUE = "#193863"; // dark blue was the correct form. This is the form that CleoQc suggested worked one year ago.

This was replaced (unfortunately without marking it as deprecated) by the Msg constants, so they could be used in JSON without making the direct JavaScript variable references (critical for the Android and iOS implementations).

This also has the benefit of adding a level of indirection that unbinds load ordering constraints between the block definitions and the constant values. The message dereferencing occurs at block creation time instead of at JavaScript/JSON load time.

PR #1749 will ensure all predefined blocks use the Msg constants at all locations.

[rachel-fenichel]

Fixed by #1749.