April 2018 release #1782

rachel-fenichel · 2018-04-14T01:22:54Z

Bugs fixed in this release (not all bugs were present on master):

Proposal for extensible input/field types from the JSON block definition #1584 (Proposal for extensible input/field types from the JSON block definition)
Broken tooltip: BKY_TEXT_CREATE_JOIN_ITEM_TOOLTIP #1613 (Broken tooltip: BKY_TEXT_CREATE_JOIN_ITEM_TOOLTIP)
Var id instead of var name in tooltip #1619 (Var id instead of var name in tooltip)
Test blocks in Playground #1626 (Test blocks in Playground)
Cannot drag from toolbox a procedure definition with arguments #1642 (Cannot drag from toolbox a procedure definition with arguments)
jsdoc warnings: @type does not permit a description #1649 (jsdoc warnings: @type does not permit a description)
If block definition has invalid color, creating/loading fails/throws #1633 (If block definition has invalid color, creating/loading fails/throws)
New field registration code does not work under advanced compilation #1671 (New field registration code does not work under advanced compilation)
New field registration code does not work under advanced compilation #1671 (Split events.js by event type, and move into a subdirectory)
Tracking issue for pointer events #1655 (Tracking issue for pointer events)
Deprecated lua code is generated #1695 (Deprecated lua code is generated)
Hook to add items in main context menu #391 (Hook to add items in main context menu)
z-order in custom dialogs demo #1704 (z-order in custom dialogs demo)
Blockly.Mutator.findParentWs is @package #1699 (Blockly.Mutator.findParentWs is @Package)
un/bindEvent_ is package-private #1726 (un/bindEvent_ is package-private)
Blockly background is always black in latest Edge (41) when there is a non-zero number of blocks present #1484 (Blockly background is always black in latest Edge (41) when there is a non-zero number of blocks present)
Support pinch-to-zoom #1295 (Support pinch-to-zoom)
Blocks with variables shouldn't show "create var getter" option in context menu when in flyout #1741 (Blocks with variables shouldn't show "create var getter" option in context menu when in flyout)
getAddedVariables fails on IE #1745 (getAddedVariables fails on IE)
Cannot remove single block from a stack anymore. #1485 (Cannot remove single block from a stack anymore.)
Overriding color constants does not override all blocks with given color #1648 (Overriding color constants does not override all blocks with given color)
Delete areas broken in RTL Mutators on FF #1425 (Delete areas broken in RTL Mutators on FF)
Make math_number a 1 by default. #1659 (Make math_number a 1 by default.)
Context menu create option shows id on blocks with variables #1658 (Context menu create option shows id on blocks with variables)
logic_compare: Type-verification creates top level shadow block as a side effect #1408 (logic_compare: Type-verification creates top level shadow block as a side effect)

Release notes:

Implement Proposal for extensible input/field types from the JSON block definition #1584 (Proposal for extensible input/field types from the JSON block definition)
Don’t register mouse events if pointer events are supported
Fix Broken tooltip: BKY_TEXT_CREATE_JOIN_ITEM_TOOLTIP #1613 (Broken tooltip: BKY_TEXT_CREATE_JOIN_ITEM_TOOLTIP)
Reduce size of XML by omitting empty variable tag.
Update Closure to 20180204.0.0
Delete extra variables at the end of a procedure argument edit
Adding test blocks into the playground
Adding an <iframe> wrapper page for testing
Fix Var id instead of var name in tooltip #1619 (Var id instead of var name in tooltip)
Fix Test blocks in Playground #1626 (Test blocks in Playground)
BlockFactory: Fixing incorrect html
Serialize variable IDs in procedure definitions (Fix Cannot drag from toolbox a procedure definition with arguments #1642)
Adding new playground test category "Drag"
Update comment on loop types
Fix some annotations (Fix jsdoc warnings: @type does not permit a description #1649)
Adding test blocks for Unicode and Emojis
Print a warning if block JSON color value is invalid (Fixes If block definition has invalid color, creating/loading fails/throws #1633)
Comments on generator test workspace save files
Random typos.
Move ordinal in block 'text_getSubstring'
move events.js into an events folder inside core
Move event classes into separate files, and update requires accordingly
Field.Variable's dispose should be on the prototype
Use @nocompress annotation to fix advanced compilation. (Fixes New field registration code does not work under advanced compilation #1671)
Don't register mouse events if pointer events are supported
Pointer Event fixes (Fixes Tracking issue for pointer events #1655)
Move away from math.log10 and math.pow in Lua generators. (Fixes Deprecated lua code is generated #1695)
Expose block ID in SVG.
Fix lots of compiler warnings and annotations
Add hook for custom context menus on the workspace (Fixes Hook to add items in main context menu #391)
Custom Dialogs demo: Bumping backdrop Z. (Fixes z-order in custom dialogs demo #1704)
Add IDs to bubbles.
Add warning_level directives to build.
Use dataset instead of ID.
Don't compute (useless) location of trashcan while workspace is being built
Prevent fatal errors in browsers that don't support dataset.
Fix Blockly.Mutator.findParentWs is @package #1699 (Blockly.Mutator.findParentWs is @Package)
Add source code link to custom dialog demo.
Tighten line length rule from 120 to 100
Add keyword-spacing rule to eslint
Make bind/unbindEvent_ public
Dragging blocks towards the toolbox should create blocks rather than do nothing
Add @this annotations in blocks/text.js
Stop storing IDs on every block in our datastore. (In demos)
Create an empty pattern if there is no grid (Fixes Blockly background is always black in latest Edge (41) when there is a non-zero number of blocks present #1484)
Enable touch gestures and pinch-to-zoom (Fixes Support pinch-to-zoom #1295)
Don't show create VAR and create Function context menu options when in the flyout (Fixes Blocks with variables shouldn't show "create var getter" option in context menu when in flyout #1741)
Add a test block with a dropdown containing both text and images
Fixes getAddedVariables fails on IE #1745 (getAddedVariables fails on IE)
Snap a single block from a stack (if meta key is pressed)
Allow block xml disable tag to be more accepting
Strip coordinates from storage of single block stacks. (In demos)
Add a function to scroll the workspace to center on a given block
Add argsIgnorePattern to the eslintrc
Simple tests for getContentDimensions
Making all blocks use the MSG colour values. (Fixes Overriding color constants does not override all blocks with given color #1648)
Work around a problem with RTL mutators (Fixes Delete areas broken in RTL Mutators on FF #1425)
Create a script to do local builds of core Blockly.
Require goog.userAgent in the correct files.
Remove rogue line breaks in translated messages.
Setting the value of math_numnber toolbox blocks to 123. (Fixes Make math_number a 1 by default. #1659)
Fix context menus on blocks with variables (Fixes Context menu create option shows id on blocks with variables #1658)
Rewrote LOGIC_COMPARE_ONCHANGE_MIXIN to fix logic_compare: Type-verification creates top level shadow block as a side effect #1408

Errantly forced whole block to rerender, including fields that had not yet been initialized. Fixes #1609

Remove forceRerender() from FieldDropDown.init()

Implement #1584 - Fields now registered by their JSON type name, allowing new custom fields and overriding of the standard fields. Replaces the manual switch statement for loading fields from JSON block definitions.

We had {% instead of %{ Fixes #1613

Reduce size of XML by omitting empty variable tag.

Updating Closure version

Delete extra variables at the end of a procedure argument edit

The new toolbox option includes a number of test blocks largely pulled from the android project, testing various configurations and edge cases.

…oswerFeature

#1638) Fix #1619. buildTooltipWithFieldValue() => buildTooltipWithFieldText() The "value" of FieldVariables was the variable id. However, we usually want the field text for the human visible tooltip. Refactoring and renaming buildTooltipWithFieldValue to use the field text.

Applies changes suggested in #1176, based off of develop.

Edge cases to test involving dragging blocks from the toolbox.

Serialize variable IDs in procedure definitions

See https://groups.google.com/d/msg/blockly/v6W3BGN9P_o/RH91g94RBAAJ

Moving TODO from doc comment to single line comment.

Update comment on loop types

Adds test blocks to demonstrate capabilities. Stopped short of adding BiDi override characters. I added to the toolbox category "Images". It isn't really images, but it didn't seem worth making a separate category at this stage.

Ignores the invalid color, defaulting to black.

...in generator test workspace files.

@rachel-fenichel

@rachel-fenichel LGTMs in person.

Create a script to do local builds of core Blockly.

Work around a problem with RTL mutators

Using 123 as a better indicator to the user this block can represent any number, and the user should replace this value with their own desired number.

* Create prevBlock_ upon first call to onchange. * Revert state upon an incompatible combination, bumping the new incompatible block, instead of the old block. Thus, the shadow is never the bumped block. Bug: * The undo stack get caught in a loop, and will never undo back to a state equivalent to the previous action.

Fix context menus on blocks with variables

Assume unplug() will recreate a new correct shadow.

Master to develop

Rewrote LOGIC_COMPARE_ONCHANGE_MIXIN to fix #1408.

Rewrote Blockly.checkBlockColourConstant_(..). * Last argument is now the expected value of the constant (replacing the `removed` argument). The prevents warnings when a Msg colour constant is overridden (the correct way). * If a value for the constant is not found, do not warn (#1790).

* Warn if jsonInit() receives a colour attribute without a value. * Extract colour init code into function. * Adding block type name to prior warnings.

googlebot · 2018-04-18T20:47:21Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

…g everything into Abstract

…as a mistake.

April 2018 release

AnmAtAnm and others added 30 commits February 13, 2018 15:01

Remove forceRerender() from FieldDropDown.

e1e3f27

Errantly forced whole block to rerender, including fields that had not yet been initialized. Fixes #1609

Merge pull request #1610 from AnmAtAnm/rm-dropdown-init-forceRerender

acaeeb4

Remove forceRerender() from FieldDropDown.init()

Customising field types using a register of fields #1584 (#1594)

54f0e06

Implement #1584 - Fields now registered by their JSON type name, allowing new custom fields and overriding of the standard fields. Replaces the manual switch statement for loading fields from JSON block definitions.

Don't register mouse events if pointer events are supported

2a00055

Fix typo in BKY message key (#1616)

551b05b

We had {% instead of %{ Fixes #1613

Reduce size of XML by omitting empty variable tag.

73417b8

Merge pull request #1617 from google/VariableXML

1996911

Reduce size of XML by omitting empty variable tag.

Updateing Closure to 20180204.0.0

446c1bb

Merge pull request #1620 from AnmAtAnm/closure-version

4c63eef

Updating Closure version

Switch to goog.events.BrowserFeature.POINTER_EVENTS

e5a2ef3

Delete extra variables at the end of a procedure argument edit

f3a4664

Cleanup

af59e27

Merge pull request #1631 from rachel-fenichel/bugfix/1544

29dc402

Delete extra variables at the end of a procedure argument edit

Adding test blocks into the playground (#1629)

d9a7f84

The new toolbox option includes a number of test blocks largely pulled from the android project, testing various configurations and edge cases.

Just check whether the window exists, instead of using goog.events.Br…

8c8412a

…oswerFeature

Adding a iframe wrapper around the playground. (#1634)

4092a64

BlockFactory: Fixing incorrect <button> html (#1622)

2aadfa6

Applies changes suggested in #1176, based off of develop.

Serialize variable IDs in procedure definitions

74fd581

Adding new playground test category "Drag" (#1643)

8fcdbf0

Edge cases to test involving dragging blocks from the toolbox.

Merge pull request #1644 from rachel-fenichel/bugfix/1642

c4d114e

Serialize variable IDs in procedure definitions

Update comment on loop types

20b7b7a

See https://groups.google.com/d/msg/blockly/v6W3BGN9P_o/RH91g94RBAAJ

Moving TODO from doc comment to single line comment.

91e2d03

Fix some JsDoc annotations (#1650)

13cb643

Merge pull request #1651 from AnmAtAnm/rm-todos-in-docs

e3700c0

Moving TODO from doc comment to single line comment.

Merge pull request #1647 from google/rachel-fenichel-patch-1

09316c6

Update comment on loop types

Adding test cases for Unicode in blocks. (#1646)

2358fe6

Adds test blocks to demonstrate capabilities. Stopped short of adding BiDi override characters. I added to the toolbox category "Images". It isn't really images, but it didn't seem worth making a separate category at this stage.

Print a warning if JSON color value is invalid. (#1639)

9cd6b1e

Ignores the invalid color, defaulting to black.

Adding warnings to not include <varaibles> (#1645)

abb0047

...in generator test workspace files.

Random typos.

10dbf2c

@rachel-fenichel LGTMs in person.

rachel-fenichel and others added 20 commits April 11, 2018 18:08

Fix my definition of plausible

01e4860

Localisation updates from https://translatewiki.net.

bdfbdee

Merge pull request #1772 from rachel-fenichel/feature/local_build

abde113

Create a script to do local builds of core Blockly.

Merge pull request #1774 from rachel-fenichel/bugfix/1425

df3e826

Work around a problem with RTL mutators

Setting the value of math_numnber toolbox blocks to 123. (#1773)

5c541c6

Using 123 as a better indicator to the user this block can represent any number, and the user should replace this value with their own desired number.

Fix context menus on blocks with variables

2366666

Fix comment

1dfb53b

Merge pull request #1777 from rachel-fenichel/bugfix/1658

91f3634

Fix context menus on blocks with variables

Merge branch 'master' into master_to_develop

b5ac0b7

Rebuild core files

f49521b

Do not reconnect a previous shadow block.

ef23b0e

Assume unplug() will recreate a new correct shadow.

Merge pull request #1781 from rachel-fenichel/master_to_develop

eaafc23

Master to develop

Merge pull request #1778 from AnmAtAnm/shadow-pop

f52b75a

Rewrote LOGIC_COMPARE_ONCHANGE_MIXIN to fix #1408.

Rebuild all files

1fdf109

Fix #1788

6d93807

Correct block color reference in demos/graph (#1794)

b56bedb

Warn if jsonInit() receives a colour attribute without a value. (#1795)

643759a

* Warn if jsonInit() receives a colour attribute without a value. * Extract colour init code into function. * Adding block type name to prior warnings.

Rebuild compressed

240daea

rachel-fenichel added 4 commits April 19, 2018 17:44

Create base classes for block and variable events, instead of stuffin…

453fa01

…g everything into Abstract

Remove unnecessary conditionals.

2e83750

Move events back up to core, because moving it to a separate folder w…

dba3375

…as a mistake.

Rebuild

19dd26a

rachel-fenichel merged commit 7679d22 into master Apr 20, 2018

rachel-fenichel deleted the rc/april_2018 branch April 20, 2018 16:51

AnmAtAnm mentioned this pull request Apr 20, 2018

Updating .js files from web master 7679d22 google/blockly-android#722

Merged

ntzm mentioned this pull request May 18, 2018

Bump blockly version mo4islona/node-blockly#23

Closed

SybelBlue pushed a commit to SybelBlue/blockly that referenced this pull request May 24, 2019

Merge pull request google#1782 from google/rc/april_2018

a7c33de

April 2018 release

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

April 2018 release #1782

April 2018 release #1782

rachel-fenichel commented Apr 14, 2018

googlebot commented Apr 18, 2018

April 2018 release #1782

April 2018 release #1782

Conversation

rachel-fenichel commented Apr 14, 2018

Bugs fixed in this release (not all bugs were present on master):

Release notes:

googlebot commented Apr 18, 2018