Fix #1619. buildTooltipWithFieldValue() => buildTooltipWithFieldText() #1638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ext. The "value" of FieldVariables was the variable id. However, we usually want the field text for the human visible tooltip. Refactoring and renaming buildTooltipWithFieldValue to use the field text.
core/extensions.js
Outdated
| @@ -423,7 +423,7 @@ Blockly.Extensions.buildTooltipWithFieldValue = function(msgTemplate, | |||
| var extensionFn = function() { | |||
| this.setTooltip(function() { | |||
| return Blockly.utils.replaceMessageReferences(msgTemplate) | |||
| .replace('%1', this.getFieldValue(fieldName)); | |||
| .replace('%1', this.getField(fieldName).getText()); | |||
There was a problem hiding this comment.
Check if the field exists and use the empty string if it doesn't
rachel-fenichel
approved these changes
Feb 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fix #1619
The "value" of FieldVariables was the variable id.
However, we want the field text for the human visible tooltip. Refactoring and renaming
buildTooltipWithFieldValueto use the field text.Proposed Changes
buildTooltipWithFieldValue()to use field text, instead of value. Rename accordingly.Reason for Changes
#1619
Test Coverage
Tested on: