Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Var id instead of var name in tooltip #1619

Closed
AnmAtAnm opened this issue Feb 14, 2018 · 1 comment · Fixed by #1782
Closed

Var id instead of var name in tooltip #1619

AnmAtAnm opened this issue Feb 14, 2018 · 1 comment · Fixed by #1782
Labels
issue: bug Describes why the code or behaviour is wrong

Comments

@AnmAtAnm
Copy link
Contributor

AnmAtAnm commented Feb 14, 2018 •
edited
Loading

Loops: "Count with i from 1 to 10 by 1"

screen shot 2018-02-14 at 2 20 17 pm

Seen in rc/feb_2018
@AnmAtAnm AnmAtAnm added issue: bug Describes why the code or behaviour is wrong affects: develop labels Feb 14, 2018
@rachel-fenichel
Copy link
Collaborator

Present on all of these blocks:
image

@rachel-fenichel rachel-fenichel mentioned this issue Feb 16, 2018
Closed
3 tasks
AnmAtAnm added a commit to AnmAtAnm/blockly that referenced this issue Feb 17, 2018
@AnmAtAnm
Fix google#1619. buildTooltipWithFieldValue => buildTooltipWithFieldT…
ee7e67a 
…ext.

The "value" of FieldVariables was the variable id.
However, we usually want the field text for the human visible tooltip.
Refactoring and renaming buildTooltipWithFieldValue to use the field
text.
@AnmAtAnm AnmAtAnm mentioned this issue Feb 17, 2018
Merged
3 tasks
AnmAtAnm added a commit that referenced this issue Feb 17, 2018
@AnmAtAnm
Fix #1619. buildTooltipWithFieldValue() => buildTooltipWithFieldText() (
f45c6fa 
#1638)

Fix #1619. buildTooltipWithFieldValue() => buildTooltipWithFieldText()

The "value" of FieldVariables was the variable id.
However, we usually want the field text for the human visible tooltip.
Refactoring and renaming buildTooltipWithFieldValue to use the field
text.
@rachel-fenichel rachel-fenichel mentioned this issue Apr 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue: bug Describes why the code or behaviour is wrong
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

April 2018 release google/blockly
2 participants
@AnmAtAnm @rachel-fenichel