Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks with variables shouldn't show "create var getter" option in context menu when in flyout #1741

Closed
samelhusseini opened this issue Mar 28, 2018 · 2 comments · Fixed by #1782

Comments

@samelhusseini
Copy link
Contributor

Problem statement

Blocks with variables as inputs shouldn't show the create variable getter in their context menus when inside a flyout. (Just like variable getter / setter blocks)

creategetvariable

screen shot 2018-03-27 at 11 27 46 pm

screen shot 2018-03-27 at 11 25 20 pm

Expected Behavior

Context menu doesn't show the create getter option when inside the flyout.

Actual Behavior

Context menu does show the option, and when clicking on the option, the getter is created and orphaned inside the flyout workspace.

Steps to Reproduce

  1. Start by opening the Loops category in the Blockly playground.
  2. Next, right click on the for block and select the 'Create "get VARIABLE_ID"' block (variable id should be variable name, see Variable context menu create getter option prints out variable id instead of name #1740)
  3. Click on that option. (A new variable_get block is created but it is orphaned inside of the flyout workspace)

Operating System and Browser

Tested on Chrome.
Should repro on all.

Additional Information

@samelhusseini
Copy link
Contributor Author

Same issue with functions and their 'create function' option.

@samelhusseini
Copy link
Contributor Author

This is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant