Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getAddedVariables fails on IE #1745

Closed
jandrewb opened this issue Mar 29, 2018 · 1 comment · Fixed by #1782
Closed

getAddedVariables fails on IE #1745

jandrewb opened this issue Mar 29, 2018 · 1 comment · Fixed by #1782
Labels
component: browser help wanted External contributions actively solicited issue: bug Describes why the code or behaviour is wrong

Comments

@jandrewb
Copy link
Contributor

Problem statement

The getAddedVariables function calls the "includes" function on an array, which is not supported in IE. Maybe this should call indexOf instead?

Expected Behavior

Blockly workspaces with variables should load from XML without errors on IE.

Actual Behavior

IE has a Javascript error when loading a workspaces with variables. The error says "includes" is not a function.

Steps to Reproduce

  1. Create and save a workspace with variable blocks to XML
  2. Try restoring the workspace from XML on IE.

Stack Traces

Operating System and Browser

  • Windows Internet Explorer 11
@rachel-fenichel rachel-fenichel added issue: bug Describes why the code or behaviour is wrong component: browser help wanted External contributions actively solicited labels Mar 29, 2018
@rachel-fenichel
Copy link
Collaborator

Definitely unintentional. Want to make a pull request?

jandrewb added a commit to jandrewb/blockly that referenced this issue Mar 30, 2018
@jandrewb
Fix google#1745
c7c35e9
jandrewb added a commit to jandrewb/blockly that referenced this issue Mar 30, 2018
@jandrewb
Fix google#1745
237a7d5
This was referenced Mar 30, 2018
Closed
Merged
rachel-fenichel added a commit that referenced this issue Mar 30, 2018
@rachel-fenichel
Merge pull request #1751 from jandrewb/jandrewb-patch-1
ccca62b 
Fix #1745
@rachel-fenichel rachel-fenichel mentioned this issue Apr 14, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: browser help wanted External contributions actively solicited issue: bug Describes why the code or behaviour is wrong
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

April 2018 release google/blockly
2 participants
@rachel-fenichel @jandrewb