Dummy input aligns only left

[pavelkestefran]

Describe the bug

Dummy input currently does not align right (or center).
Last working in 2.20190722.1

To Reproduce

1. In blockly factory create a block similar to :

Blockly.Blocks['block_type'] = {
  init: function() {
    this.appendDummyInput()
        .appendField("something long");
    this.appendDummyInput()
        .setAlign(Blockly.ALIGN_CENTRE)
        .appendField("a");
    this.appendDummyInput()
        .setAlign(Blockly.ALIGN_RIGHT)
        .appendField("a");
    this.setColour(230);
 this.setTooltip("");
 this.setHelpUrl("");
  }
};

Expected behavior

Fields in Dummy input should respect selected alignment.

Screenshots

Current master:

2.20190722.1:

Desktop (please complete the following information):

• OS: Win10
• Browser Firefox
• Version 70.0

[RoboErikG]

@rachel-fenichel looks like we're missing some logic for dummy input rows. Value inputs and statement inputs do center and right alignment correctly.

@pkestefran are you depending on the alignment in a live app or is this just something you noticed in the developer tools?

[pavelkestefran]

@RoboErikG The behavior is the same in the live app. I have noticed this while testing new changes in blockly with custom blocks we have in our app. We have multiple right aligned dummy inputs within our blocks. For now we will stay with 2.20190722.1

[RoboErikG]

Thanks, that means we may need to do another patch then.

[samelhusseini]

We've fixed this and released a patch v3.20191014.4.
Thanks for reporting.

[pavelkestefran]

Works great. Thank you for quick release. :)

[pavelkestefran]

@samelhusseini I played a bit with test blocks in playground and noticed that the alignment is unfortunately still not respected in Zelos and Minimalist renderers. Geras and Thrasos are ok.

While we are ok, as we use Geras only, the behavior should be consistent.
Can you please check? Thank you.

[samelhusseini]

Hey @pkestefran. The current POR is for Zelos is to not support external value inputs (only inline) like other renderers. We made the call to only add the logic in geras and thrasos.
I don't see a reason why the minimalist renderer shouldn't at least take somehow take into account its input's alignment properties (albeit it is a lower priority for us right now). @rachel-fenichel

I've filed an issue to track this: #3361