Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimalist renderer doesn't account for input alignment #3361

Closed
samelhusseini opened this issue Oct 29, 2019 · 2 comments
Closed

Minimalist renderer doesn't account for input alignment #3361

samelhusseini opened this issue Oct 29, 2019 · 2 comments
Labels
component: rendering issue: bug Describes why the code or behaviour is wrong low priority

Comments

@samelhusseini
Copy link
Contributor

Describe the bug

The minimalist renderer doesn't account for any of its inputs alignment properties.

To Reproduce

Open the playground, switch to test blocks, switch to the minimalist renderer.
Open the Align category. Notice how none of the inputs are aligned properly.

Expected behavior

Unclear, but it seems the base renderer should at least take into account the input's alignment properties.

Screenshots
Screen Shot 2019-10-29 at 9 47 32 AM

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Stack Traces

Replace with error stack trace.

Additional context

@samelhusseini samelhusseini added issue: bug Describes why the code or behaviour is wrong component: rendering issue: triage Issues awaiting triage by a Blockly team member labels Oct 29, 2019
@samelhusseini samelhusseini added low priority and removed issue: triage Issues awaiting triage by a Blockly team member labels Oct 29, 2019
@rachel-fenichel
Copy link
Collaborator

Good call. Align is fundamental enough that it should be in the base renderer.

@samelhusseini
Copy link
Contributor Author

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: rendering issue: bug Describes why the code or behaviour is wrong low priority
Projects
None yet
Development

No branches or pull requests

2 participants