Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make alignment common renderer behaviour #3498

Merged
merged 2 commits into from
Dec 11, 2019

Conversation

samelhusseini
Copy link
Contributor

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

The details

Resolves

Fixes #3361

Proposed Changes

Rather than it just being in geras and thrasos. Make alignment common to all renderers.

Reason for Changes

Zelos rendering.

Test Coverage

Tested geras and zelos in playground (with test blocks).

Tested on:

Documentation

Additional Information

@samelhusseini samelhusseini merged commit 2b335dc into google:develop Dec 11, 2019
@samelhusseini samelhusseini deleted the alignment_common branch December 11, 2019 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants