feat: add JSO serialization and deserialization of variables #5131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
alschmiedt
approved these changes
Jul 30, 2021
BeksOmega
force-pushed
the
cereal/variables
branch
from
3c02cb3 to
2e5b479
Compare
BeksOmega
changed the title
BeksOmega
force-pushed
the
cereal/variables
branch
from
b9bdd5f to
36964e1
Compare
BeksOmega
added a commit
to BeksOmega/blockly
that referenced
this pull request
Sep 13, 2021
…ryPiFoundation#5131) * Add variable serialization tests * Fix requires for new file * Add serialization and deserialization of variables * Remove only in tests * Cleanup
BeksOmega
added a commit
that referenced
this pull request
Sep 17, 2021
* Add variable serialization tests * Fix requires for new file * Add serialization and deserialization of variables * Remove only in tests * Cleanup
alschmiedt
pushed a commit
to alschmiedt/blockly
that referenced
this pull request
Sep 20, 2021
…ryPiFoundation#5131) * Add variable serialization tests * Fix requires for new file * Add serialization and deserialization of variables * Remove only in tests * Cleanup
alschmiedt
pushed a commit
that referenced
this pull request
Sep 20, 2021
* Add variable serialization tests * Fix requires for new file * Add serialization and deserialization of variables * Remove only in tests * Cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
Link for Diff: BeksOmega/blockly@cereal/connnected-blocks...BeksOmega:cereal/variables
The details
Resolves
Work on project cereal
Dependent on #5120
Proposed Changes
Adds serialization and deserialization of variables as JSOs.
Reason for Changes
Saving state is good.
Test Coverage
Added tests to ensure that serialized variables have the correct format.