Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove @internal tag from isDragTowardWorkspace #7462

Closed
1 task done
BeksOmega opened this issue Sep 5, 2023 · 8 comments · Fixed by #7529
Closed
1 task done

Remove @internal tag from isDragTowardWorkspace #7462

BeksOmega opened this issue Sep 5, 2023 · 8 comments · Fixed by #7529
Assignees
@ramyaram2092
Labels
ghc-osd Reserved for open source day: https://anitab-org.github.io/open-source-day/ good first issue issue: feature request Describes a new feature and why it should be added size: small Bugs that can be picked up and completed in 1-3 days

Comments

@BeksOmega
Copy link
Collaborator

BeksOmega commented Sep 5, 2023 •
edited
Loading

🚧⚠️🚧 This issue is being saved for Grace Hopper Open Source Day. 🚧⚠️🚧 An event we're running to help girls and non-binary technologists make their first contributions to open source! Please see our list of help wanted issues if you'd like to contribute!

Check for duplicates

  • I have searched for similar issues before opening a new one.

Problem

isDragTowardWorkspace is part of the I_Flyout interface. Having it marked as @internal means that subclasses of Flyout can't easily override it. This makes it difficult for external developers to create custom flyouts.

Request

Remove the @internal tag from isDragTowardWorkspace in Flyout, FlyoutVertical, and FlyoutHorizontal

Alternatives considered

N/A

Additional context

Part of #7215
@BeksOmega BeksOmega added issue: feature request Describes a new feature and why it should be added good first issue ghc-osd Reserved for open source day: https://anitab-org.github.io/open-source-day/ labels Sep 5, 2023
@BeksOmega BeksOmega moved this to Needs Detail in Blockly GHC OSD Sep 5, 2023
@BeksOmega BeksOmega mentioned this issue Sep 5, 2023
Closed
3 tasks
@BeksOmega BeksOmega added the size: small Bugs that can be picked up and completed in 1-3 days label Sep 5, 2023
@saymedgm
Copy link

saymedgm commented Sep 6, 2023

@BeksOmega can you please assign me this issue

@NikoRaisanen NikoRaisanen mentioned this issue Sep 6, 2023
Closed
1 task
@NikoRaisanen
Copy link

Hey @BeksOmega! I just opened a PR for this issue, let me know if you want any changes

@BeksOmega BeksOmega moved this from Needs Detail to Ready for Work in Blockly GHC OSD Sep 6, 2023
@ramyaram2092
Copy link
Contributor

I would like to work on this

@KrautRock
Copy link

KrautRock commented Sep 22, 2023 •
edited
Loading

.

@ajita86
Copy link

ajita86 commented Sep 22, 2023

Hi! Can I be assigned to this?

@ramyaram2092
Copy link
Contributor

@BeksOmega I think you have assigned this to a person that has commented two weeks ago

@Patty8122
Copy link

@BeksOmega I am interested in this as well!

This was referenced Sep 22, 2023
Closed
Closed
Merged
@Shreyagundu
Copy link

@BeksOmega I am interested in this as well! Can I be assigned to this?

@github-project-automation github-project-automation bot moved this from Ready for Work to Done in Blockly GHC OSD Sep 22, 2023
@BeksOmega BeksOmega moved this from Done Coding to Needs Testing in Blockly GHC OSD Sep 29, 2023
@BeksOmega BeksOmega moved this from Needs Testing to Done Testing in Blockly GHC OSD Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ramyaram2092 ramyaram2092

Labels
ghc-osd Reserved for open source day: https://anitab-org.github.io/open-source-day/ good first issue issue: feature request Describes a new feature and why it should be added size: small Bugs that can be picked up and completed in 1-3 days
Projects
No open projects
Blockly GHC OSD
Status: Done Testing
Milestone
No milestone
8 participants
@ajita86 @BeksOmega @Shreyagundu @NikoRaisanen @saymedgm @ramyaram2092 @KrautRock @Patty8122