feat: made the method isDragTowardWorkspace non private #7529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lyOut Made horizontal and vertical flyouts non private
ramyaram2092
changed the title
ramyaram2092
changed the title
johnnesky
approved these changes
Sep 22, 2023
johnnesky
changed the title
johnnesky
requested changes
Sep 22, 2023
johnnesky
approved these changes
Sep 22, 2023
|
Excellent, thank you for the great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes 7462
Proposed Changes
I have removed @internal tag from flyout_horizontal.ts and flyout_vertical.ts files
Reason for Changes
made the method non -private to create custom layouts
Test Coverage
Documentation
Additional Information