Lint rule updates #1716
Merged
Lint rule updates #1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
None
Proposed Changes
keyword-spacingrule to our.eslintrc, and fix issues.max-lenrule to limit to 100 and ignore strings and regexp.Reason for Changes
Updates that @macherel pointed out in #1579. (Sorry for the delay in adding them.)
Test Coverage
Tested with
eslint .Additional Information
According to the google style guide we should limit line lengths to 80 characters. There are too many errors for me to do that right now, but I enforce it for new code where reasonable.