Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move a test function into utils #1910

Merged
merged 1 commit into from
Jun 8, 2018

Conversation

rachel-fenichel
Copy link
Collaborator

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

The details

Resolves

None

Proposed Changes

Move the temporary event firing function into test_utilities.

Reason for Changes

It's used in files other than event_test (where it was previously defined).

Test Coverage

Jsunit

Copy link
Contributor

@picklesrus picklesrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rachel-fenichel rachel-fenichel merged commit 0c1de91 into google:develop Jun 8, 2018
@rachel-fenichel rachel-fenichel deleted the tests/move_utils branch June 8, 2018 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants