fix: unit tests were using strict equality testing for numeric results; now check 15 decimals #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s. Modified to check for 15 decimals of precision. Now the exp unit test passes.
|
Note that this fix is for the Javascript version of the unit tests, I didn't investigate Python or Dart to see if they have the same issue. |
NeilFraser
added a commit
that referenced
this pull request
Oct 30, 2014
fix: unit tests were using strict equality testing for numeric results; now check 15 decimals
|
Looks great to me. Thanks. |
|
Thanks for accepting my first ever open source pull request. :-) |
quachtina96
referenced
this pull request
in quachtina96/blockly
Jun 29, 2016
Cleaned up and commented code, boolean block still not working correctly
AnmAtAnm
added a commit
to AnmAtAnm/blockly
that referenced
this pull request
Apr 19, 2017
11 tasks
rachel-fenichel
pushed a commit
that referenced
this pull request
Dec 13, 2017
HiDeoo
pushed a commit
to HiDeoo/blockly
that referenced
this pull request
May 28, 2019
Add children search
3 tasks
3 tasks
chia-lun
added a commit
to milnel2/blockly
that referenced
this pull request
Jun 7, 2021
Closed
4 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "exp" test in the Math unit tests was failing, despite expected and actual results being almost identical. I modified the assertEquals function to use 15 decimals of precision when comparing numbers, which seems reasonable based on discussion here:
http://www.w3schools.com/js/js_numbers.asp
I also tried 17 decimals, which still failed, and 16 decimals, which passed but I figured I'd be a little more conservative. All other math unit tests still pass.