Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Proposed Changes
#2142
Reason for Changes
Quote from Issue:
Test Coverage
1 . Turned on "Log events" in the playground.
2 . Hit the "Spaghetti" button.
3 . Observed how a FinishedLoading event was correctly fired. (pass)
1 . Changed the following code ~ln 251 in playground:
To:
2 . Hit the "Spaghetti" button.
3 . Observed how a FinishedLoading event (with the correct group) was fired. (pass)
1 . Added the following code at ~ln 256 in playground (at the top of the spaghettiXml var):
' <shadow type="controsl_if"></shadow>',
2 . Hit the "Spaghetti" button.
3 . Observed how the FinishedLoading event was not fired, because an error was thrown. (pass)
Tested on:
Additional Information
I'm not sure the FinishedLoading event needed to be in a new file, but I couldn't decide where else to put it. If it does need to be in a new file, I'm not sure if the copyright should be updated to 2019 or not.