Remove closure base file dependency #2976
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Shave off 28KB from Blockly compressed.
Proposed Changes
Because we made use of a number of closure's base methods, we had a need to include closure's base file. Since we only use very few of these methods, we can trim down our binary size even further by providing alternatives for the following:
goog.exportSymbol
andgoog.mixin
can be moved to Blockly.utils and re-implemented.goog.provide
andgoog.require
are built in and the compiler knows how to handle those. We do need to stub those though, because our message files include a require and provide call.goog.inherits
I've toyed with a few ideas of what to do with this one, but the least intrusive solution I came up with was to just inject an implementation of it.@NeilFraser thoughts?
Reason for Changes
Less closure (save 28KB)
Test Coverage
Tested the demos.