Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes blocks flying when mutator is open #4289

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Fixes blocks flying when mutator is open #4289

merged 1 commit into from
Sep 17, 2020

Conversation

alschmiedt
Copy link
Contributor

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

The details

Resolves

Reverts part of #3468 in order to fix #4175.
Remaining issue is documented in #4288.

Proposed Changes

Set rendered = false before mutating a block.

Reason for Changes

Test Coverage

Tested on:

Documentation

Additional Information

rachel-fenichel
rachel-fenichel approved these changes Sep 17, 2020
View reviewed changes
Copy link
Collaborator

@rachel-fenichel rachel-fenichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once travis passes.

Travis feels quite flaky recently.

@alschmiedt alschmiedt merged commit 2523da5 into google:develop Sep 17, 2020
@alschmiedt alschmiedt deleted the fix_mutator_bug branch October 23, 2020 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachel-fenichel rachel-fenichel rachel-fenichel approved these changes

Assignees

@rachel-fenichel rachel-fenichel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alschmiedt @rachel-fenichel