Fix render issue with block factory connection dropdown #4334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachel-fenichel
approved these changes
Sep 29, 2020
alschmiedt
pushed a commit
to alschmiedt/blockly
that referenced
this pull request
Sep 30, 2020
This was referenced Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
https://groups.google.com/g/blockly/c/Jm4_bSpjNes/m/m6HXBZNEBwAJ
Proposed Changes
Adds a
renderedcheck before callingrenderon block added inconnectOutputShadow_.Reason for Changes
The change in #4296 caused issues with the block factory connection dropdown field. The
rendercall inconnectOutputShadow_is triggered when the validator is called indomToHeadless_and throws an error.Test Coverage
Tested on:
Additional Information
Previously an error was not thrown because
initSvgwas called before the dropdown field was processed. Reverting the PR would cause issues with variable models, but adding arenderedcheck before callingrenderseems reasonable.