Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding parameter to dragEnter and dragExit #4890

Merged
merged 11 commits into from
Jun 11, 2021
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix interface
kozbial committed Jun 11, 2021
commit b3cecbdbf2c45c819cfa17f656d4ee96266c9678
4 changes: 3 additions & 1 deletion core/drag_target.js
Original file line number Diff line number Diff line change
@@ -49,8 +49,10 @@ Blockly.DragTarget.prototype.onDragEnter = function(_dragElement) {
/**
* Handles when a cursor with a block or bubble is dragged over this drag
* target.
* @param {!Blockly.Block|!Blockly.IBubble} _dragElement The block or bubble
* currently being dragged.
*/
Blockly.DragTarget.prototype.onDragOver = function() {
Blockly.DragTarget.prototype.onDragOver = function(_dragElement) {
// no-op
};

2 changes: 2 additions & 0 deletions core/interfaces/i_drag_target.js
Original file line number Diff line number Diff line change
@@ -45,6 +45,8 @@ Blockly.IDragTarget.prototype.onDragEnter;
/**
* Handles when a cursor with a block or bubble is dragged over this drag
* target.
* @param {!Blockly.Block|!Blockly.IBubble} dragElement The block or bubble
* currently being dragged.
*/
Blockly.IDragTarget.prototype.onDragOver;