Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-export Blockly.utils.* submodules from Blockly.utils #5465

Merged
merged 2 commits into from
Sep 16, 2021
Merged

Re-export Blockly.utils.* submodules from Blockly.utils #5465

merged 2 commits into from
Sep 16, 2021

Conversation

cpcallen
Copy link
Contributor

The basics

  • I branched from goog_module
  • My pull request is against goog_module
  • My code follows the style guide
  • I have run npm test.

The details

Resolves

Part of #5026

Proposed Changes

Remove the Have utils.js reexport all of the Blockly.utils.* modules in core/utils/*.js

Additional Information

I'm going to mark this as draft until the issues surrounding versioning / unpkging of dev-tools are clarified a bit.

@cpcallen cpcallen added this to the 2021_q3_release milestone Sep 14, 2021
@google-cla google-cla bot added the cla: yes Used by Google's CLA checker. label Sep 14, 2021
@alschmiedt
Copy link
Contributor

One of the questions that came up from this PR was:

Should test helpers be in core instead of separate plugin that core has to import?
Yes, it makes more sense for them to be in core eventually. However, because we have not figured out multiple entry points having these in core causes a size concern. Once we figure out multiple entry points this should be moved into core from blockly samples. All of the plugins that rely on the test helpers would then be able to get the test helpers from the blockly version they already install. I added #5466 to track the issue.

@cpcallen cpcallen marked this pull request as ready for review September 15, 2021 15:29
@cpcallen cpcallen requested a review from a team as a code owner September 15, 2021 15:29
@rachel-fenichel rachel-fenichel mentioned this pull request Sep 15, 2021
Closed
@cpcallen
Reexport Blockly.utils.* modules from Blockly.utils
4306b5a
@cpcallen
Update metadata (file sizes) again
8f8a8d6 
blockly_compressed.js has gotten too big for the second time this
quarter.  Update the expected file sizes for it so that tests
will continue to pass.
@cpcallen
Copy link
Contributor Author

OK, this just needs a code review.

rachel-fenichel
rachel-fenichel approved these changes Sep 16, 2021
View reviewed changes
Copy link
Collaborator

@rachel-fenichel rachel-fenichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpcallen cpcallen merged commit 51d9dad into google:goog_module Sep 16, 2021
@cpcallen cpcallen deleted the reexport-utils branch September 16, 2021 17:23
@cpcallen cpcallen mentioned this pull request Sep 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rachel-fenichel rachel-fenichel rachel-fenichel approved these changes

@alschmiedt alschmiedt Awaiting requested review from alschmiedt

Assignees
No one assigned
Labels
cla: yes Used by Google's CLA checker. type: cleanup
Projects
None yet
Milestone
2021_q3_release
Development

Successfully merging this pull request may close these issues.
3 participants
@cpcallen @alschmiedt @rachel-fenichel