Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds a fix for npm install failing #5471

Merged
merged 4 commits into from
Sep 15, 2021

Conversation

alschmiedt
Copy link
Contributor

@alschmiedt alschmiedt commented Sep 15, 2021

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

The details

Resolves

We were having problems

Proposed Changes

Applies a work around maribeth found.

Behavior Before Change

Npm install on CI was breaking.

Behavior After Change

Npm install now works.

Reason for Changes

We don't' know why it just started failing. But we got the following failure when trying to install:

npm ERR! Error while executing:

npm ERR! /usr/bin/git ls-remote -h -t ssh://git@github.com/fivetran/doctrine.git

Test Coverage

Documentation

Additional Information

@alschmiedt alschmiedt requested a review from a team as a code owner September 15, 2021 19:27
@google-cla google-cla bot added the cla: yes Used by Google's CLA checker. label Sep 15, 2021
@alschmiedt alschmiedt marked this pull request as draft September 15, 2021 19:28
@github-actions github-actions bot added this to the 2021_q3_release milestone Sep 15, 2021
@BeksOmega BeksOmega removed their request for review September 15, 2021 19:51
@alschmiedt alschmiedt changed the title test Adds a fix for npm install failing Sep 15, 2021
@alschmiedt alschmiedt changed the title Adds a fix for npm install failing fix: adds a fix for npm install failing Sep 15, 2021
@alschmiedt alschmiedt marked this pull request as ready for review September 15, 2021 20:11
@alschmiedt alschmiedt merged commit 0e43ddc into google:goog_module Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by Google's CLA checker. type: cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants