Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: playground test blocks, text area listeners, and show/hide buttons #6015

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

BeksOmega
Copy link
Collaborator

@BeksOmega BeksOmega commented Mar 21, 2022

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

N/A

Proposed Changes

Makes it so that:

  1. Test blocks are accessible.
  2. The text area properly triggers updates.
  3. The show and hide buttons work.

Behavior Before Change

None of those things worked.

Behavior After Change

Now they work!

Reason for Changes

Need to be able to use the playground for testing.

Test Coverage

Tested on:

  • Desktop Chrome

Documentation

N/A

Additional Information

Abby figured out how to get the test blocks to import! They need to be added as a plain script instead of a module script (I think b/c we're using the dist version). I didn't think that would work b/c Blockly wouldn't be defined. But it turns out prepare.js defines Blockly in the global scope. So as long as we load the test blocks after we load prepare.js everything is happy :D

@BeksOmega BeksOmega requested a review from a team as a code owner March 21, 2022 20:59
@BeksOmega BeksOmega requested review from gonfunko and alschmiedt and removed request for gonfunko March 21, 2022 20:59
@BeksOmega BeksOmega merged commit 7abf3de into google:develop Mar 21, 2022
@BeksOmega BeksOmega deleted the fix/playground-listeners branch April 5, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants