fix: json hooks for lists blocks not needing extra state #6177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeksOmega
approved these changes
Jun 3, 2022
cpcallen
reviewed
Jun 14, 2022
| title: | ||
| 'JSON with XML extra state', | ||
| json: { | ||
| ...serializedJson, |
There was a problem hiding this comment.
I was confused about why a build of a clean checkout of develop was resulting in changes to tests/deps.mocha.js. It turns out that this use of ... meant that lists_test.js went from being ES6 to ES2018, and closure-make-deps tries to update testsd/deps.mocha.js accordingly, but that that update was not included in the same commit.
Not worth fixing now, since PR #6205 is about to delete the deps files from the repo, but a useful reminder to us all to keep an eye out for changes to generated files and try make sure they get checked in at the same time as the change which caused them least we confuse our colleagues…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
#6176
Proposed Changes
Don't serialize xml mutations to extra state in json serialization for
Behavior Before Change
xml mutations were serialized in json extra state and deserialized
Behavior After Change
xml mutations no longer serialized and are ignored on deserialization
Reason for Changes
Test Coverage
Added basic roundtrip (de)serialization tests, including with previous extra state
Documentation
Additional Information