Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): Support TypeScript in core/ #6220

Merged
merged 8 commits into from
Jun 16, 2022
Merged

feat(build): Support TypeScript in core/ #6220

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f32a229
fix(tests): Use tsc-compiled base.js to allow use of goog.js
cpcallen Jun 14, 2022
5c3d72b
docs(build): JSDoc update for JSCOMP_WARNING
cpcallen Jun 16, 2022
70516d5
refactor(utils): Convert utils/deprecation.js to TypeScript
cpcallen Jun 16, 2022
6484e42
chore(utils): Update utils/deprecation.ts from MigranTS output
cpcallen Jun 16, 2022
ca23daa
feat(build): clang-format .ts files
cpcallen Jun 16, 2022
412e848
fix(build): Fix sources for advanced compilation test
cpcallen Jun 16, 2022
2a07141
fix(build): Disable checkTypes diagnostic group
cpcallen Jun 16, 2022
284103e
chore(utils): Use @internal where we previously used @package
cpcallen Jun 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions core/utils/deprecation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,22 +22,21 @@ goog.declareModuleId('Blockly.utils.deprecation');

/**
* Warn developers that a function or property is deprecated.
* @param {string} name The name of the function or property.
* @param {string} deprecationDate The date of deprecation.
* @param name The name of the function or property.
* @param deprecationDate The date of deprecation.
* Prefer 'month yyyy' or 'quarter yyyy' format.
* @param {string} deletionDate The date of deletion, in the same format as the
* @param deletionDate The date of deletion, in the same format as the
* deprecation date.
* @param {string=} opt_use The name of a function or property to use instead,
* if any.
* @param opt_use The name of a function or property to use instead, if any.
* @alias Blockly.utils.deprecation.warn
* @package
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace package with internal rather than deleting it: https://api-extractor.com/pages/tsdoc/tag_internal/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Done.
  2. Turns out this involves suppressing nonStandardJsDocs. But no problem.
  3. Note that the @package annotation was deleted by the tooling that converted this file to TS, not by me. This will be a headache…

*/
const warn = function(name: string, deprecationDate: string, deletionDate: string, opt_use?: string) {
export function warn(
name: string, deprecationDate: string, deletionDate: string,
opt_use?: string) {
let msg = name + ' was deprecated on ' + deprecationDate +
' and will be deleted on ' + deletionDate + '.';
' and will be deleted on ' + deletionDate + '.';
if (opt_use) {
msg += '\nUse ' + opt_use + ' instead.';
}
console.warn(msg);
};
export {warn};
}