Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Theme.name does not match registered name (#6186) #6226

Merged
merged 2 commits into from
Jun 23, 2022
Merged

fix: Theme.name does not match registered name (#6186) #6226

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
401d801
fix: Theme.name does not match registered name (#6186)
derwehr Jun 18, 2022
81da4fc
chore(tests): add test for defineTheme normalizing to lower case
derwehr Jun 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/theme.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ class Theme {
* @return {!Theme} A new Blockly theme.
*/
static defineTheme(name, themeObj) {
name = name.toLowerCase();
const theme = new Theme(name);
let base = themeObj['base'];
if (base) {
Expand Down