fix!: remove unused or obsolete useragent checks #6355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachel-fenichel
force-pushed
the
remove_useragents
branch
from
dc4fb7a to
55eff7b
Compare
|
I'm not sure if this counts as a chore or a fix. It addresses a requested follow-up from #6336. |
BeksOmega
reviewed
Aug 17, 2022
rachel-fenichel
added
breaking change
rachel-fenichel
changed the title
|
Good catch. Changed to be a breaking change. |
BeksOmega
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Followup from #6336
Proposed Changes
Remove exported useragent booleans for chrome, webkit, ipod, and tablet.
Behavior Before Change
No change.
Behavior After Change
No change.
Reason for Changes
We weren't using these checks, and it's fragile for us to be maintaining and exporting them if we're not using them.
Test Coverage
Standard tests. We'll want to test on iOS for the release, but it should only impact sound loading anyway.
Documentation
Additional Information
Developers who were using these values should read the MDN page on browser detection using the user agent. If there is no way to detect what you're looking for without checking the user agent, follow the instructions on that page to find the most targeted possible solution.