-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: TS errors on dependent projects with certain tsconfig settings (#6360) #6361
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello and thank you for sending us this useful pull request; it is appreciated!
It mostly looks great, but there is one place where I am hoping you might be able to suggest a better choice of name, and another where I think there is an actual error in our type definitions (maybe several errors) that should be fixed.
Assigning to @maribethb for follow-up review as I will be on annual leave until 20th August. |
ac7789e
to
c72bb9a
Compare
Ok, addressed comments in the PR. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes! LGTM =) If/once CI passes I'll go ahead and merge this, and it will go into our next release!
The basics
npm run format
andnpm run lint
The details
Resolves
resolves #6360
Proposed Changes
Fairly minor refactoring to bypass some typescript errors appearing on dependent projects with certain tsconfig settings.
Behavior Before Change
N/A. No behavioral changes.
Behavior After Change
N/A. No behavioral changes.
Reason for Changes
Test Coverage
Existing tests should cover my changes:
Generator#workspaceToCode
parseToolboxTree
Block#tostring
Ran
npm run test
and all existing tests passed.