Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: context menu not working #6399

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Conversation

BeksOmega
Copy link
Collaborator

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide
  • I ran npm run format and npm run lint

The details

Resolves

N/A

Proposed Changes

Fixes the context menu, which was not working if you clicked on the text.

Behavior Before Change

Clicking on the text of a context menu option would not trigger the action.

Behavior After Change

Clicking on the text does trigger the action.

Reason for Changes

Fixing bugs is fun :D

Test Coverage

Manually tested that clicking context menu options works.

Documentation

N/A

Additional Information

N/A

@BeksOmega BeksOmega requested a review from a team as a code owner August 30, 2022 23:02
@BeksOmega BeksOmega requested a review from maribethb August 30, 2022 23:02
@BeksOmega BeksOmega added the PR: fix Fixes a bug label Aug 30, 2022
@BeksOmega BeksOmega merged commit 79051a6 into google:develop Aug 31, 2022
@BeksOmega BeksOmega deleted the fix/context-menu branch October 4, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants