Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: path object not checking theme props #6451

Merged
merged 2 commits into from
Sep 26, 2022
Merged

fix: path object not checking theme props #6451

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a9447b
fix: path object not checking theme props
BeksOmega Sep 26, 2022
64f4013
fix: error msgs
BeksOmega Sep 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions core/renderers/geras/path_object.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,11 @@ export class PathObject extends BasePathObject {
override applyColour(block: BlockSvg) {
this.svgPathLight.style.display = '';
this.svgPathDark.style.display = '';
if (!this.style.colourTertiary) {
throw new Error(
'The renderer did not properly initialize the tertiary colour of ' +
'the block style');
}
this.svgPathLight.setAttribute('stroke', this.style.colourTertiary);
this.svgPathDark.setAttribute('fill', this.colourDark);

Expand Down Expand Up @@ -118,6 +123,11 @@ export class PathObject extends BasePathObject {
override updateShadow_(shadow: boolean) {
if (shadow) {
this.svgPathLight.style.display = 'none';
if (!this.style.colourSecondary) {
throw new Error(
'The renderer did not properly initialize the secondary colour ' +
'of the block style block style');
}
this.svgPathDark.setAttribute('fill', this.style.colourSecondary);
this.svgPath.setAttribute('stroke', 'none');
this.svgPath.setAttribute('fill', this.style.colourSecondary);
Expand Down