fix: parent blocks not bumping neighbours #6538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribethb
approved these changes
Oct 13, 2022
| const neighbours = connection.neighbours(config.snapRadius); | ||
| for (let j = 0, otherConnection; otherConnection = neighbours[j]; j++) { | ||
| const renderedOther = otherConnection as RenderedConnection; | ||
| // If both connections are connected, that's probably fine. But if |
There was a problem hiding this comment.
I think this comment in particular and probably the other ones are helpful context to leave in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
#6017
Proposed Changes
makes it so that whenever a block in a block stack has
bumpNeighbourscalled on it, all of the connections in the block stack bump.We have to bump every single connection, because with custom renderers, we can't predict how blocks will be shaped based on other blocks. E.g. in geras higher sibling connections don't move, but in other renderers they might. So we have to trigger bumping on everything.
Behavior Before Change
Parent blocks would not bump neighbours when a child block was rerendered.
Behavior After Change
Parent blocks do bump neighbours when a child block is rerendered.
Reason for Changes
Having blocks appear tto be connected (visually) without actually being connected (in terms of code generation) can cause confusing results and frustration for end-users. This helps eliminate that.
Test Coverage
N/A
Documentation
N/A
Additional Information
Also did some code cleanup of
bumpNeighbourswhile I was in the area.