chore: fix mutator blocks jumping #6559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribethb
approved these changes
Oct 18, 2022
There was a problem hiding this comment.
Spent a long time trying to understand the original change + this.
It looks like before the original change the transform attribute was set to skew + translate, and after that change it's only set to skew. I wonder if that's the whole problem?
Or part of the problem is block_svg is still using the skew_ and translate_ properties, so if we just don't set them here, things go weird?
Either way this change LGTM and also filing a bug to fix this up is good.
cpcallen
pushed a commit
to cpcallen/blockly
that referenced
this pull request
Oct 19, 2022
* chore: fix mutator blocks jumping * chore: format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Fixes #6541
Proposed Changes
Reverts changes made in #6301 that caused jumping.
Reason for Changes
Bugs are bad.
Test Coverage
Manually tested the repro steps from #6541
Documentation
N/A
Additional Information
Thank you to Maribeth for the bisect + cherrypick idea!
Also for now I've just reverted the bug-causing changes. But I'm also going to file a bug for actually refactoring this system to be more testable + less stateful + not use private properties on svg elements.