refactor(blocks): Migrate blocks/procedures.js to TypeScript
#7192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 21, 2023
BeksOmega
reviewed
Jun 21, 2023
| if (quarkId in this.quarkConnections_) { | ||
| const connection = this.quarkConnections_[quarkId]; | ||
| // TODO(#6920): investigate claimed circular initialisers. |
There was a problem hiding this comment.
What does "circular intialisers" refer to?
There was a problem hiding this comment.
From #6920:
setProcedureParameters_unexpectedly required declarations of the types of thequarkIdandconnectionlocal variables avoid "implicitly has type 'any' because it does not have a type annotation and is referenced directly or indirectly in its own initializer" errors. Since the definitions do not appear to be circular (thoughconnectionis initialised based onquarkId) this smells and probably warrants further investigation.
| field.setValidator(this.validator_); | ||
| // Hack: override showEditor to do just a little bit more work. | ||
| // We don't have a good place to hook into the start of a text edit. | ||
| field.oldShowEditorFn_ = field.showEditor_; | ||
| field.oldShowEditorFn_ = (field as AnyDuringMigration).showEditor_; |
There was a problem hiding this comment.
Maybe add a TODO comment pointing at #6920 for this?
cpcallen
added a commit
to cpcallen/blockly
that referenced
this pull request
Jun 21, 2023
(Replaces an earlier commit that inadvertently introduced a syntax error.)
cpcallen
force-pushed
the
fix/6828/blocks/procedures
branch
from
2ebe4a0
to
46bbd87
Compare
BeksOmega
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
Part of #6828.