fix: insertion marker position when connection is resized (#7426) #7482
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
clementcontet
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:
-
You can find tips about contributing to Blockly and how to
validate your changes on our
developer site. -
All contributors must sign the Google Contributor License
Agreement (CLA). If the google-cla bot leaves a comment on this
PR, make sure you follow the instructions. -
We use conventional commits
to make versioning the package easier. Make sure your commit
message is in the proper format
or learn how to fix it. -
If any of the other checks on this PR fail, you can click on
them to learn why. It might be that your change caused a test
failure, or that you need to double-check the
style guide.
Thank you for opening this PR! A member of the Blockly team will review it soon.
| y: closest.y - imConn.y, | ||
| }; | ||
| const originalOffsetInBlock = imConn.getOffsetInBlock().clone(); | ||
| const imConnConst = imConn; |
There was a problem hiding this comment.
nit: You don't need to assign this to another variable. You can just pass it directly.
There was a problem hiding this comment.
Hum, no.
These values are modified during the render.
That's why I get their "original" value in constants before the render.
The basics
The details
Resolves
Fixes #7426
Proposed Changes
When positioning the insertion marker, take into account that its connection may have been resized.
Reason for Changes
With these changes, when positioning the insertion marker, we ensure that the target connection will not move.
Test Coverage
I tested in the playground with Zelos and Geras that insertion markers don't move target connections anymore, even if their connection have been resized.
Documentation
N/A