refactor(generators): Migrate Lua generators to TypeScript #7654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btw17
commented
Nov 17, 2023
cpcallen
approved these changes
Nov 18, 2023
generators/lua/lua_generator.ts
Outdated
| @@ -5,40 +5,38 @@ | |||
| */ | |||
|
|
|||
| /** | |||
| * @fileoverview Helper functions for generating Lua for blocks. | |||
| * @file Helper functions for generating Lua for blocks. | |||
There was a problem hiding this comment.
For consistency with the other CodeGenerator subclasses:
Suggested change
| * @file Helper functions for generating Lua for blocks. | |
| * @file Lua code generator class, including helper methods for | |
| * generating Lua for blocks. |
(But now I've noticed that I forgot to replace @fileoverview with @file in lots of places in the other generators…)
generators/lua/lua_generator.ts
Outdated
| import {inputTypes} from '../../core/inputs/input_types.js'; | ||
|
|
||
|
|
||
| /** | ||
| * Order of operation ENUMs. | ||
| * http://www.lua.org/manual/5.3/manual.html#3.4.8 | ||
| * @enum {number} |
There was a problem hiding this comment.
The @enum JSDoc tag is no longer needed and should be deleted.
generators/lua/lua_generator.ts
Outdated
Comment on lines
29
to
37
| HIGH = 1, // Function calls, tables[] | ||
| EXPONENTIATION = 2, // ^ | ||
| UNARY = 3, // not # - ~ | ||
| MULTIPLICATIVE = 4, // * / % | ||
| ADDITIVE = 5, // + - | ||
| CONCATENATION = 6, // .. | ||
| RELATIONAL = 7, // < > <= >= ~= == | ||
| AND = 8, // and | ||
| OR = 9, // or |
There was a problem hiding this comment.
Please restore the original formatting here and use // prettier-ignore to preserve it.
|
Thanks for merging this and resolving the small tweaks after! I was out last week, so I would've have been able to get to it until this morning. |
cpcallen
added a commit
to cpcallen/blockly
that referenced
this pull request
Mar 15, 2024
In PRs google#7602, google#7616, google#7646, google#7647 and google#7654 the @Protected access modifier on scrub_ was not transcribed to the new typescript signature. BREAKING CHANGE: This makes scrub_ protected again, which will break any code attempting to access this method from outside a CodeGenerator subclass.
cpcallen
added a commit
to cpcallen/blockly
that referenced
this pull request
Mar 15, 2024
Fixes google#2156. In PRs google#7602, google#7616, google#7646, google#7647 and google#7654 the @Protected access modifier on scrub_ on the CodeGenerator subclasses was not transcribed to the new typescript signature. I was going to re-add it, but this breaks some of the procedure block generator functions which rely on it, and then @BeksOmega pointed out that this might be one of the CodeGenerator API functions which we had already decided should be public—and lo and behold I found google#2156. Per discussion amongst team, I am not renaming it to scrub at this time.
cpcallen
added a commit
to cpcallen/blockly
that referenced
this pull request
Mar 15, 2024
Fixes google#2156. In PRs google#7602, google#7616, google#7646, google#7647 and google#7654 the @Protected access modifier on scrub_ on the CodeGenerator subclasses was not transcribed to the new typescript signature. I was going to re-add it, but this breaks some of the procedure block generator functions which rely on it, and then @BeksOmega pointed out that this might be one of the CodeGenerator API functions which we had already decided should be public—and lo and behold I found google#2156. Per discussion amongst team, I am not renaming it to scrub at this time.
cpcallen
added a commit
to cpcallen/blockly
that referenced
this pull request
Mar 15, 2024
Fixes google#2156. In PRs google#7602, google#7616, google#7646, google#7647 and google#7654 the @Protected access modifier on scrub_ on the CodeGenerator subclasses was not transcribed to the new typescript signature. I was going to re-add it, but this breaks some of the procedure block generator functions which rely on it, and then @BeksOmega pointed out that this might be one of the CodeGenerator API functions which we had already decided should be public—and lo and behold I found google#2156. Per discussion amongst team, I am not renaming it to scrub at this time.
1 task
cpcallen
added a commit
that referenced
this pull request
Mar 15, 2024
Fixes #2156. In PRs #7602, #7616, #7646, #7647 and #7654 the @Protected access modifier on scrub_ on the CodeGenerator subclasses was not transcribed to the new typescript signature. I was going to re-add it, but this breaks some of the procedure block generator functions which rely on it, and then @BeksOmega pointed out that this might be one of the CodeGenerator API functions which we had already decided should be public—and lo and behold I found #2156. Per discussion amongst team, I am not renaming it to scrub at this time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Part of #6828.
Proposed Changes
Migrate
generators/lua/*.jsandgenerators/lua.jsto TypeScript.Reason for Changes
Finish TS migration.
Test Coverage
npm testpasses. No changes to manual test procedures required.Documentation
No changes to documentation yet, as there should be minimal changes to the generated code and no changes to the published typings (because during build we overwrite the generated
.d.tsfiles with the ones fromtypings/).Additional Information
It may be easier to review this commit-by-commit, as the final format commit make a lot of noisy changes.