fix(build): Reintroduce shims for subpackage entrypoints #8050
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Proposed Changes
Reintroduce shims (
dist/core.js
,dist/blocks.js
,dist/javascript.js
, etc.) for submodule entrypoints in top level of package. Have them created bypackage_tasks.js
directly, rather than being copied fromscripts/package/
.Assumptions:
core-node.js
. This is reasonable since there's little reason to bundle code for node.js, and node.js has supported the exports clause since at least v12, considerably older than any version of node.js we officially support.Reason for Changes
The v11 beta breaks builds for external developers using browserify.
This change should solve issues encountered by users of bundlers that don't support
exports
at all (e.g. browserify) as well as ones that don't support it in certain circumstances (e.g., when using webpack's [resolve.alias] configuration option](https://webpack.js.org/configuration/resolve/#resolvealias) to alias 'blockly' to 'node_modules/blockly', as we formerly did in most plugins, which causes webpack to ignore blockly's
package.json` entirely).Documentation
We should mention in next beta release notes that even bundlers that do not support
exports
should continue to work.Additional Information
This is in effect a partial rollback of PR #7822.