Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lang file imports #8179

Merged
merged 1 commit into from
May 28, 2024
Merged

fix: lang file imports #8179

merged 1 commit into from
May 28, 2024

Conversation

BeksOmega
Copy link
Collaborator

The basics

The details

Resolves

Fixes #8174

Proposed Changes

Makes it so that lang files with dashses can be imported properly by changing the name of the import we use to use underscores instead.

Test Coverage

#8174 no longer reproduces.

Documentation

N/A

Additional Information

This needs to go in the patch this week.

@BeksOmega BeksOmega requested a review from a team as a code owner May 28, 2024 13:51
@BeksOmega BeksOmega requested a review from maribethb May 28, 2024 13:51
@github-actions github-actions bot added the PR: fix Fixes a bug label May 28, 2024
@BeksOmega BeksOmega merged commit 933e210 into google:develop May 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot import message files with filename that contain hyphens in v11
2 participants